Skip to content

ci: Gate manual release workflows on wait-for-checks#70

Merged
vdusek merged 2 commits into
masterfrom
ci/consolidate-checks-and-gate-releases
May 26, 2026
Merged

ci: Gate manual release workflows on wait-for-checks#70
vdusek merged 2 commits into
masterfrom
ci/consolidate-checks-and-gate-releases

Conversation

@vdusek
Copy link
Copy Markdown
Contributor

@vdusek vdusek commented May 26, 2026

Summary

Ports the CI consolidation and wait-for-checks adoption from crawlee-python to apify-shared-python. See apify/crawlee-python#1913 for the original rationale and PR description; the follow-up permission fixes from #1914 and #1915 are referenced for completeness (this repo has no docs workflows so no extra permission grants are needed).

Two commits:

  1. Consolidate check workflows into a single Checks workflow — merges _check_code.yaml, _check_package.yaml, and _tests.yaml into a single _checks.yaml. Every check now carries the shared Checks / prefix. unit_tests is gated on a run_tests input so on_master.yaml can keep skipping tests for ci/docs commits.
  2. Gate manual release workflows on wait-for-checks — replaces the inline code_checks / tests jobs in manual_release_stable.yaml and manual_release_beta.yaml with an apify/actions/wait-for-checks@v1.2.0 step that verifies the Checks workflow already passed on the dispatch commit (it runs via on_master.yaml on every push).

vdusek and others added 2 commits May 26, 2026 09:09
Merge _check_code.yaml, _check_package.yaml, and _tests.yaml into a single
_checks.yaml that exposes each check as a job. Reduces duplication across
on_master.yaml and on_pull_request.yaml and gives every check the shared
`Checks /` prefix. unit_tests carries `if: inputs.run_tests` so
on_master.yaml can keep skipping tests for "ci" and "docs" commits.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Replace each release workflow's inline code/tests checks with a
`wait-for-checks` step that verifies the `Checks` workflow already passed
on the dispatch commit (it runs via `on_master.yaml` on every push). Adds
the gate to the stable and beta release workflows that previously had
none.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@vdusek vdusek added t-tooling Issues with this label are in the ownership of the tooling team. adhoc Ad-hoc unplanned task added during the sprint. labels May 26, 2026
@vdusek vdusek self-assigned this May 26, 2026
@vdusek vdusek requested a review from janbuchar May 26, 2026 07:13
@github-actions github-actions Bot added this to the 141st sprint - Tooling team milestone May 26, 2026
@vdusek vdusek merged commit 0eb9422 into master May 26, 2026
25 checks passed
@vdusek vdusek deleted the ci/consolidate-checks-and-gate-releases branch May 26, 2026 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants